Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent ifcVersion in IDS testcases #273

Closed
andyward opened this issue Apr 10, 2024 · 3 comments · Fixed by #276
Closed

Inconsistent ifcVersion in IDS testcases #273

andyward opened this issue Apr 10, 2024 · 3 comments · Fixed by #276
Labels
documentation Improvements or additions to documentation tests
Milestone

Comments

@andyward
Copy link
Contributor

Most of the testcases in the IDS folder (10 out of 12 in development) seem to have an ifcVersion inconsistent with their corresponding test IFC file. i.e. they have an ifcVersion="IFC2X3" in the IDS specification, but a FILE_SCHEMA('IFC4') in the IFC. In all other testcases IFC4 is used consistently.

I'm assuming it's an oversight - apart from for pass-specification_version_is_purely_metadata_and_does_not_impact_pass_or_fail_result.ids

More generally, what is the thinking on the use of ifcVersion during model validation? Looking at ids/pass-specification_version_is_purely_metadata_and_does_not_impact_pass_or_fail_result.ids it seems that it should be ignored in terms of the test outcome?

It feels like it would be appropriate to at least warn the user the model may not be compatible with the specification, given the spec may be written to account for schema-specific concepts?

@CBenghi
Copy link
Contributor

CBenghi commented Apr 11, 2024

Unfortunately, I still don't have an implementation of verification engine to spot these issues.

My view is that the IFC schema version should be considered.
Indeed I think that wee need a richer regression suite that include such test cases, including pass and fail tests.

A PR is welcome if you can help.

@CBenghi CBenghi added documentation Improvements or additions to documentation tests labels Apr 11, 2024
@CBenghi CBenghi added this to the 1.0 milestone Apr 11, 2024
andyward added a commit to andyward/IDS that referenced this issue Apr 11, 2024
@andyward
Copy link
Contributor Author

Thanks Claudio. I've put a PR in for these IDS files. It's mainly just to avoid confusion amongst implementors over what the test case is testing.

I've also finally made our xbim IDS verification engine public at https://github.com/xBimTeam/Xbim.IDS.Validator - will update the implementors links via another PR, as this should be a pretty comprehensive & robust IDS 0.97 /1.0 implementation for anyone using Microsoft .NET (including cross platform Core support)

@CBenghi
Copy link
Contributor

CBenghi commented Apr 19, 2024

Thanks @andyward,
I will have to update the scripts.md file, because IDS files are generated, then accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants