Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove occurrence tracking for attributeType #149

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Remove occurrence tracking for attributeType #149

merged 1 commit into from
Apr 5, 2023

Conversation

CBenghi
Copy link
Contributor

@CBenghi CBenghi commented Apr 4, 2023

As per Pasi's proposal on #144, there's no sense in making an attribute requirement optional.

@CBenghi CBenghi mentioned this pull request Apr 4, 2023
Open
pjanck
pjanck approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this change.

@berlotti berlotti merged commit a1dbca3 into buildingSMART:master Apr 5, 2023
@pjanck pjanck mentioned this pull request Apr 5, 2023
Closed
@CBenghi CBenghi deleted the pr/attributeCardinality branch April 5, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanck pjanck pjanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CBenghi @pjanck @berlotti