Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development of final standard #254

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Development of final standard #254

merged 7 commits into from
Feb 29, 2024

Conversation

berlotti
Copy link
Member

buildingSMART Validation phase

CBenghi and others added 7 commits October 23, 2023 18:01
the next version of the schema is prepared, upon which every schema
change will be developed.

Only schema versions merged int the main branch will stay unchanged.
Schemas in development can be modified until merged into main.
The value has been limited to 1, this was a mistake in the schema
definition, it was alsways interpreted as 1 by the implementers.
Fix: cardinality of restriction not as intended.
Prepared change to allow multiple material facets
* Improving clarify of datatype and Property facet

- The schema is changed to be more expressive with capitalization
- The documentation better expresses the capitalization of datatypes
- Improved units page

* Working on #203

- [x] improved documentation
- [x] change the schema to move MinMaxOccurs to applicability
- [x] update audit tool
- [ ] correct test cases appropriately

* Added OMA back with fixes.

* Updated tooling

* Updated tooling

* Improved specification documentation

* Changed the cardinality of requirement facets

Changed to an expressive enum, where alreadu applicable.
Type does not allow for prohibitions, as we prefer to use enumeration
to restrain the allowed values.

Cardinality of attributes is to be discussed in a separate issue #144

* Modified development files per call agreement

We have still to discuss Optional cardinality for facets.
OMA uses it for classification and property.

* Further work on the specification document page.

* Documentation proposal for all facet configuratitions.

* All schema changes previously discussed.

* Further fixes discussed in the call today.

* Revised Development files.

* Update Development/IDS_random_example.ids

Spelling fixed.

Co-authored-by: Stefan Jaud <59165496+pjanck@users.noreply.github.com>

* Schema change, cardinality made CamelCase.

* doc changes.

* Added testcases generation and improved schema

Improved documentation in the XSD file with documentation and
minor consistency changes.

Updated all testcases to latest schema.
Ids testcases are generated from the documentation/testcases/scripts.md
via the SchemaProject folder.

The next step is to integrate this feature in the automated targets

* Fixed IDS files

- completed information on Development files
- documentation: dataType adjusted to valid scenarios
- testcases adjusted for  audit:
  - attribute/pass-an_optional_facet_always_passes_regardless_of_outcome removed
  - improved empty classification systems (requiring at least a letter).
  - improved entity constraints
  - improved material tests
  - improved partof tests

* All testcases pass IDS auditing deliberately

A new class of tests (invalid) has been added, to mark
tests that should fail IFC verification and and are also invalid for
the audit tool.

* Completed the unit documentation.

* Schema changes from SCTE consultation

- propertyType.name renamed to baseName
- EntityType.subType renamed to predefinedType
- Improved documentation

* Corrected some test cases.

* Improved units.md

- removed units that never require conversion
- corrected unit capitalization according to SI
- consistent spacing in Unit symbols

---------

Co-authored-by: Stefan Jaud <59165496+pjanck@users.noreply.github.com>
@berlotti berlotti merged commit 6d71cdf into master Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants