Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format of values in IDS #290

Closed
CBenghi opened this issue May 5, 2024 · 1 comment
Closed

Format of values in IDS #290

CBenghi opened this issue May 5, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation tests
Milestone

Comments

@CBenghi
Copy link
Contributor

CBenghi commented May 5, 2024

A few test cases state that Booleans must be specified as uppercase strings.

### Booleans must be specified as uppercase strings 1/3
``` ids attribute/fail-booleans_must_be_specified_as_uppercase_strings_1_3.ids
Booleans must be specified as uppercase strings 1/3
Entity: ''IFCTASK''
Requirements:
Attribute: ''IsMilestone'',''TRUE''
```
### Booleans must be specified as uppercase strings 2/3
``` ids attribute/fail-booleans_must_be_specified_as_uppercase_strings_2_3.ids
Booleans must be specified as uppercase strings 2/3
Entity: ''IFCTASK''
Requirements:
Attribute: ''IsMilestone'',''False''
```
### Booleans must be specified as uppercase strings 2/3
``` ids attribute/pass-booleans_must_be_specified_as_uppercase_strings_2_3.ids
Booleans must be specified as uppercase strings 2/3
Entity: ''IFCTASK''
Requirements:
Attribute: ''IsMilestone'',''FALSE''
```

I think this is unreasonable.

If the whole point of using xml's xs:restriction in IDS is to allow implementers to use an existing XML library for parts of the testing, surely we must comply with the XML approach for the storage of values.

In the case of Boolean, according to xml official documentation this means that:

An instance of a datatype that is defined as boolean can have the following legal literals {true, false, 1, 0}.

This should be verified across all XML base types.

@CBenghi CBenghi added documentation Improvements or additions to documentation tests labels May 5, 2024
@CBenghi CBenghi added this to the 1.0 milestone May 5, 2024
@CBenghi CBenghi self-assigned this May 5, 2024
@CBenghi
Copy link
Contributor Author

CBenghi commented May 6, 2024

Closed with #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests
Projects
None yet
Development

No branches or pull requests

1 participant