-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get twiglet and db #18
Conversation
…matted by Boom, if we want custom data we have to add it ourself.
…ary order of function arguments.
…epeats throughout the app without too much copy paste. It could actually even be better, but I will leave that to further consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the refactor of getTwigletInfoAndDB. Nice work
|
|
… more than 500 lines of comma dangles.
Okay, the rule is now enforced and it changed a lot of files. We now have the trailing comma everywhere it can be. |
I don't necessarily agree with changing linting rules as part of this branch (although I prefer the trailing commas too, and seems like it must not have been consistently enforced?) Since we all prefer trailing commas (and we're the current dev team on Twig) I think this change is okay, but we should avoid changing any more linting rules as part of this PR and focus on the task at hand, which is updating all the packages and making sure tests pass. |
@lizziesz I agree no further linting rule changes. When I initially reviewed the pr, I only saw places where there had been a trailing comma that was removed in the new code - so I wanted them put back. I couldn't see places where a trailing comma had not existed previously, if there were any, because they weren't changes. So I don't know whether any inconsistency had existed before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add that I haven't said already.
Resolved most of the todos.