did I do this right? #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aochsner
added a commit
that referenced
this pull request
Jul 18, 2017
Add twig-backup job creation * remove timestamps() * Attempt to gen the twig-backup job via job-dsl * new name for now * apparently dsl files can't have dashes * attempt to sandbox * okay bad idea * put in backups folder * nevermind re: folders for now * test-branching branch and see if will overwrite * wild guess * WAG #2 * WAG #3 * This should now be stable
BenAychh
pushed a commit
that referenced
this pull request
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So after discussing the migration with Mike yesterday he suggested we abstract the pouch db stuff away from the twig api and use a DAO to make the migration over to Dynamo more switch-flippy. Not sure how well that will work if we change the data model (do we abstract even further out in case the data model changes?) when this goes to dynamo but thoughts on my first attempt. Rip it apart. Both e2e and unit tests passed without me needing to change anything about them so I think I did something right... Or maybe those tests need to stop stubbing couch and start stubbing the Dao? How deep does this rabbit-hole go?