Copyandpaste #1
Merged
Copyandpaste #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 10, 2017 10:55
BenAychh
suggested changes
Jan 11, 2017
|
|
||
| copyNode() { | ||
| this.stateService.userState.setCopiedNodeId(); | ||
| this.subscription = this.stateService.twiglet.nodes.observable.subscribe((response: OrderedMap<string, Map<string, any>>) => { |
There was a problem hiding this comment.
This probably needs an unsubscribe or we can just subscribe to all of the nodes in ngOnInit like we do with the userstate on line 33.
| @@ -23,6 +23,14 @@ describe('UserStateService', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('can set the copied node id to the current node id', () => { | |||
|
|
||
| @HostListener('window:keydown', ['$event']) | ||
| handleKeyDown($event) { | ||
| if (($event.metaKey || $event.ctrlKey) && $event.code === 'KeyC' && !this.disabled) { |
There was a problem hiding this comment.
metaKey is the control key on windows so I think you can drop your or $event.ctrlKey and just use metaKey to support all operating systems.
| this.disabled = !response.get('isEditing'); | ||
| this.cd.markForCheck(); | ||
| userStateServiceResponseToObject.bind(this)(response); | ||
| if (!this.userState.currentNode) { |
There was a problem hiding this comment.
Do you need to set current node to an empty string or can you just leave the null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.