Add a command parameter and support arrays for command and shell #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It dawned on @toolmantim and I that a good solution to the question of whether this plugin and
docker-compose
should default to a shell is the following:yarn install && yarn start
in examples:The above will translate to
/bin/sh -e -c 'yarn install && yarn run test'
in the container. This will also support multiple line commands.command
this PR introduces:This avoids us having to do any shell word parsing, which is horrible for complexity and security.
The new array syntax is also applied to
entrypoint
andshell
: