Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable git submodules #168

Merged
merged 1 commit into from
Jul 5, 2015
Merged

Conversation

toolmantim
Copy link
Contributor

Allows using the agent in environments that don't have Perl, which the git submodule commands rely upon.

Related to #52

@blueimp
Copy link
Contributor

blueimp commented Jul 4, 2015

Thanks for the quick implementation, @toolmantim!

If you change the two lines with

if [[ ! -z "${BUILDKITE_DISABLE_GIT_SUBMODULES:-}" ]]; then

to

if [[ -z "${BUILDKITE_DISABLE_GIT_SUBMODULES:-}" ]]; then

it will work fine. :)

From the naming of the variable, I guess you wanna check if BUILDKITE_DISABLE_GIT_SUBMODULES is empty, rather than not empty before executing the git submodule calls.

@toolmantim
Copy link
Contributor Author

Whoops, fixed. Give that a go and happy to merge into master if it works 👍

Allows using the agent in environments that don't have Perl, which the
git submodule commands rely upon.
@blueimp
Copy link
Contributor

blueimp commented Jul 5, 2015

Tested and works! 👍

toolmantim added a commit that referenced this pull request Jul 5, 2015
Add ability to disable git submodules
@toolmantim toolmantim merged commit ff250ef into master Jul 5, 2015
@toolmantim toolmantim deleted the disable-git-submodules branch July 5, 2015 10:20
@toolmantim
Copy link
Contributor Author

@blueimp awesome! Thanks for testing. This will go out in the next agent release, which should be within the next week.

@blueimp
Copy link
Contributor

blueimp commented Jul 5, 2015

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants