Add submodule remotes to known_hosts #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithpitt
reviewed
Jul 23, 2017
bootstrap/bootstrap.go
Outdated
| func (b *Bootstrap) gitEnumerateSubmoduleURLs() ([]string, error) { | ||
| urls := []string{} | ||
|
|
||
| gitSubmoduleOutput, err := b.runCommandSilentlyAndCaptureOutput( |
There was a problem hiding this comment.
Can we get a copy/paste of what the output looks like?
|
More comments added @keithpitt! |
keithpitt
reviewed
Jul 26, 2017
bootstrap/bootstrap.go
Outdated
| // submodules might need their fingerprints verified too | ||
| if b.SSHFingerprintVerification { | ||
| commentf("Checking to see if submodule urls need to be added to known_hosts") | ||
| submoduleRepos, _ := b.gitEnumerateSubmoduleURLs() |
There was a problem hiding this comment.
We should probably show a warning if it fails for what ever reason I think, even if we just show it an continue on our merry way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add submodule remotes to known_hosts as part of the checkout process.
Fix for #503