Add --no-plugins option to agent #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
requested review from
keithpitt and
sj26
and removed request for
keithpitt
sj26
reviewed
Sep 6, 2017
| .buildkite-agent.cfg | ||
| /.agent.conf | ||
| /.agent.*.conf | ||
| /.buildkite-agent.cfg |
sj26
reviewed
Sep 6, 2017
bootstrap/bootstrap.go
Outdated
|
|
||
| // Check if we can run plugins (disabled via --no-plugins) | ||
| if b.Plugins != "" && !b.Config.PluginsEnabled { | ||
| return fmt.Errorf("This agent is isn't allowed to run plugins. To allow this, re-run this agent without the `--no-plugins` option.") |
There was a problem hiding this comment.
Is there an extra "is" in here? ;-)
There was a problem hiding this comment.
There is is. Good catch.
sj26
reviewed
Sep 6, 2017
| @@ -42,7 +43,7 @@ type Shell struct { | |||
| func New() (*Shell, error) { | |||
| wd, err := os.Getwd() | |||
| if err != nil { | |||
| return nil, fmt.Errorf("Failed to find current working directory: %v", err) | |||
| return nil, errors.Wrapf(err, "Failed to find current working directory: %v") | |||
There was a problem hiding this comment.
Yeah, me too. They are really nice.
sj26
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--no-pluginsoption to an agent, which causes as step to fail with an error if there is a plugin present:A little bit of extra technology was needed to clean up how errors are wrapped and returned from the bootstrap. Previously there was a duplication of errors from when the command failed and when the phase failed.