Handle upgrading bootstrap-path from old 2.x shell script #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolmantim
reviewed
Nov 8, 2017
| # v2 configurations will still have bootstrap-path=/usr/share/buildkite-agent/bootstrap.sh | ||
| # which will cause all sorts of wierd behaviour | ||
|
|
||
| echo "+++ :warning: Your agent configuration contains an outdated bootstrap-path reference. It can be safely removed." |
There was a problem hiding this comment.
It'd be great to make this a bit more useful. Do we have the path to the configuration file?
Maybe something like:
echo "+++ warning: Agent configuration file deprecation warning"
echo "Your agent configuration file references a bootstrap-script compatibility shim, which will be removed in Buildkite Agent 4.x+"
echo ""
echo "To fix this, remove the 'bootstrap-script' line from your agent configuration file located at:"
echo "/var/lib/buildkite-agent/buildkite-agent.cfg"
echo ""
echo "For more information, see our Buildkite Agent 3.0 upgrade guide:"
echo "https://buildkite.com/docs/agent/some-upgrade-doc"
There was a problem hiding this comment.
lox
force-pushed
the
migrate-bootstrapsh-from-2-6
branch
from
c057497
to
e5b4c62
Compare
keithpitt
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bootstrap.sh shim that gets installed at the same location as the old v2.x bootstrap that prints a warning and then runs
buildkite-agent bootstrap. This should mean that users that upgrade from v2 -> v3 don't run into problems because their config still refers to the v2 bootstrap.sh.