Handle windows paths in all usage of shellwords parsing #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
commented
Mar 14, 2018
| @@ -79,9 +80,18 @@ func (r JobRunner) Create() (runner *JobRunner, err error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| args, err := shell.Parse(r.AgentConfiguration.BootstrapScript) | |||
There was a problem hiding this comment.
This moved up here because I moved it out of process.Process so that the error can be handled better.
keithpitt
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralises our use of shellword parsing (e.g parsing something like
C:\Windows\System32\CMD.exe /S /C "bash.exe ./upload.sh"into it's respective tokens).It turns out the Windows is ok with paths with forward slashes, even for UNC paths, so this just rolls with that.
It also sneakily rolls back #683 in favour of just converting the path to the binary to one that uses backslashes.