Support --no-interpolation option in pipeline upload
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithpitt
reviewed
Apr 17, 2018
| @@ -32,6 +33,15 @@ func (p PipelineParser) Parse() (interface{}, error) { | |||
| errPrefix = fmt.Sprintf("Failed to parse %s", p.Filename) | |||
| } | |||
|
|
|||
| // If interpolation is disabled, just parse and return | |||
| if p.NoInterpolation { | |||
| var result interface{} | |||
There was a problem hiding this comment.
I think we may need to do the same logic as we do on line 50 (with the switch between a slice or a map?)
There was a problem hiding this comment.
We only do that so that we can parseWithEnv if it's a map. Without interpolation I don't think we need to do that, do we?
There was a problem hiding this comment.
Hmmmmm. We might end up with out-of-order env if we do that though.
There was a problem hiding this comment.
But we always had that, it only mattered once we started doing interpolation.
|
Let's get this one merged. I'm pretty sure that short-circuit is ok @keithpitt, as without any interpolation we don't need any of the other fancy parsing bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for interpolation to be disabled in
buildkite-agent pipeline upload.Closes #715.