Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buildkite:git:branch meta-data #753

Merged
merged 1 commit into from
May 3, 2018
Merged

Conversation

sj26
Copy link
Member

@sj26 sj26 commented May 3, 2018

We've never used this information, and it's useless anyway because we're doing detached checkouts so all it returns is:

* (HEAD detached at FETCH_HEAD)

or

* (no branch)

Turns out it can take a long time to run on big repos to tell us nothing, so just remove it.

@sj26 sj26 self-assigned this May 3, 2018
@sj26 sj26 requested review from lox and keithpitt May 3, 2018 04:48
Copy link
Contributor

@lox lox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a great idea!

@sj26 sj26 force-pushed the remove-git-branch-metadata branch from 09ad861 to fbbe4e5 Compare May 3, 2018 05:27
We've never used this information, and it's useless anyway because we're
doing detached checkouts so all it returns is:

   * (HEAD detached at FETCH_HEAD)

or

   * (no branch)
@sj26 sj26 force-pushed the remove-git-branch-metadata branch from fbbe4e5 to c01d457 Compare May 3, 2018 05:43
@sj26 sj26 merged commit fc99bcc into master May 3, 2018
@sj26 sj26 deleted the remove-git-branch-metadata branch May 3, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants