Artifactory uploader patch #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch up
pull into remote fork
|
Apologies for not catching that in review, the uploader is still an area of the agent I'm a bit blurry on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third time's the charm?
This pr gets rid of our explicit reliance on
JOB_ID.In other installations like S3 and GCS, the usage of our
upload_destinationis:BUIDLKITE_UPLOAD_DESTINATION = (gs|s3)://some-repo/$BUIDLKITE_(BUILD|JOB)_IDSince this injection happens at the time we upload artifacts, the metadata we get back during the download phase matches the exact URL we would expect. In our case, the downloader is not provided with the right
UploadDestination, because we augment it within our uploader with the appendedJOB_ID.This PR should solve that issue :)
Let me know if you have questions!