Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli annotation with term block limit #2551

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Update cli annotation with term block limit #2551

merged 3 commits into from
Nov 13, 2023

Conversation

nsuma8989
Copy link
Contributor

This CL adds info about how many term block we allow per annotation.

This CL adds info about how many term block we allow per annotation.
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2551--bk-docs-preview.netlify.app

Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for tightening, but thanks adding this information 😊

pages/agent/v3/cli_annotate.md Outdated Show resolved Hide resolved
@mbelton-buildkite
Copy link
Contributor

Looks like there's a double up on PRs adding this change. I like the version in this PR because it adds the information to an existing text block rather than adding a callout. Let's merge this one.

Sorry, I missed the earlier one (#2532).

Co-authored-by: Michael Belton <119824349+mbelton-buildkite@users.noreply.github.com>
pages/agent/v3/cli_annotate.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Belton <119824349+mbelton-buildkite@users.noreply.github.com>
Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when you're ready :)

@nsuma8989 nsuma8989 merged commit 414680d into main Nov 13, 2023
3 checks passed
@nsuma8989 nsuma8989 deleted the term_limit branch November 13, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants