Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backtick html code #64

Closed

Conversation

TheDen
Copy link

@TheDen TheDen commented May 10, 2019

We've had issues using terminal-to-html with buildkite annotations when there are backticks, which seems to conflict with CommonMark. Using the HTML encoding ` ensures that backticks won't be parsed as MarkDown.

@TheDen
Copy link
Author

TheDen commented May 10, 2019

I initially tried updating this file , i.e., something like

                b.buf.WriteString(""")
        case '/':
                b.buf.WriteString("/")
+       case '`':
+               b.buf.WriteString("`")
        default:
                b.buf.WriteRune(char)
        }

but that didn't work as expected with replacement when running the binary, and it also fails a test

go test
--- FAIL: TestRendererAgainstFixtures (0.05s)
    terminal_test.go:266: homer.sh did not match, got len 1108 and expected len 1100
FAIL
exit status 1
FAIL    github.com/TheDen/terminal      0.063s
make: *** [test] Error 1```

@ticky
Copy link
Contributor

ticky commented Jun 5, 2019

Hey @TheDen, I don’t think you should be running into those issues with it as it stands - can you shoot support@buildkite.com a link to a build where this is going wrong for you?

@TheDen
Copy link
Author

TheDen commented Jun 7, 2019

Hey @ticky no problem, I sent an email (subject has this PR url). Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants