Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils scripts -- correct order of operations #134

Merged
merged 2 commits into from
Jul 12, 2013

Conversation

AaronAsAChimp
Copy link
Contributor

So 'from ... import' lines are correctly recognized. The following example from pylint was not being correctly parsed:

#![...]/bin/python
from pylint import run_pylint
run_pylint()

@jimfulton
Copy link
Member

Thanks for the PR!

Someone will need to write a test before this can be merged.

@reinout
Copy link
Contributor

reinout commented Jul 12, 2013

The fix (for my original mistake :-) ) looks good.

I've pulled the branch into my clone so that travis can check it.
https://travis-ci.org/reinout/buildout/builds/8999768
3 out of 4 are OK. The python 3.2 one isn't, but that looks like an unrelated anomaly (a number of logging handlers that is 1 off or so).

I'm seeing the same problem with docutils' scripts, so the fix is very welcome.

jimfulton pushed a commit that referenced this pull request Jul 12, 2013
distutils scripts -- correct order of operations
@jimfulton jimfulton merged commit 7dc7b39 into buildout:master Jul 12, 2013
tseaver added a commit that referenced this pull request Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants