Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows build guide #201

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Add Windows build guide #201

merged 3 commits into from
Aug 27, 2020

Conversation

ameyer-pivotal
Copy link
Contributor

  • Adds a Windows-centric guide to the App Developer Guides
  • References new guide from the main App Journey tutorial, and from the Linux build guide

Signed-off-by: Andrew Meyer meyeran@vmware.com

@ameyer-pivotal ameyer-pivotal requested a review from a team as a code owner August 26, 2020 19:13
@ameyer-pivotal ameyer-pivotal force-pushed the windows-build-tutorial branch 3 times, most recently from 8b47126 to da6e657 Compare August 26, 2020 19:24
@ameyer-pivotal
Add Windows build guide
2e0463d 
Signed-off-by: Andrew Meyer <meyeran@vmware.com>
jromero
jromero requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great!

Requested a few minor changes.

Also, note that we've added another page recently, you might want to update the weight to co-exist with "Build an app".

content/docs/app-developer-guide/build-a-windows-app.md Outdated Show resolved Hide resolved
content/docs/app-developer-guide/build-a-windows-app.md Outdated Show resolved Hide resolved
content/docs/app-developer-guide/build-a-windows-app.md Outdated Show resolved Hide resolved
@ameyer-pivotal
Address PR comments
bf8b337 
Signed-off-by: Andrew Meyer <meyeran@vmware.com>
@ameyer-pivotal
Fix dev guide weights
3854225 
Signed-off-by: Andrew Meyer <meyeran@vmware.com>
@ameyer-pivotal
Copy link
Contributor Author

@jromero

Also, note that we've added another page recently, you might want to update the weight to co-exist with "Build an app".

Done! Thanks

@jromero jromero merged commit 4fa6697 into buildpacks:main Aug 27, 2020
github-actions bot pushed a commit that referenced this pull request Aug 27, 2020
@jromero
Merge pull request #201 from ameyer-pivotal/windows-build-tutorial
831d459 
Add Windows build guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameyer-pivotal @jromero