-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CLI documentation for pack build --tag #1266
Conversation
Closes buildpacks#1136 Signed-off-by: Ujjwal Goyal <importujjwal@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 140 140
Lines 8596 8596
=======================================
Hits 6979 6979
Misses 1180 1180
Partials 437 437
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm a slightly, slightly conflicted by this. Although the help message is correct, it implies that pack is treating a "tag" differently than other tools in the ecosystem. And it's not.
@aemengo not sure I understand, can you please elaborate? 😅 Any changes you'd suggest? |
@aemengo, I see where you are coming from. This isn't the first time this confusion has come up. I've opened a discussion for this topic. buildpacks/community#128 (comment) At this point, I'd like to consider keeping that discussion out of this PR and focus on the clarification it's provided for how the implementation currently exists. |
Accepting as-is for now but heavily considering a change to it's implementation to support "true" tags are defined by the OCI spec. See buildpacks/community#128 (comment) |
Closes #1136
Signed-off-by: Ujjwal Goyal importujjwal@gmail.com
Summary
Adds a line describing the format of tags to be supplied to
pack build image --tag
Documentation
Related
Resolves #1136