-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for platform api 0.7 and 0.8 #1334
Conversation
dd465ab
to
84132fa
Compare
Codecov Report
@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
- Coverage 80.86% 80.83% -0.02%
==========================================
Files 144 144
Lines 9152 9186 +34
==========================================
+ Hits 7400 7425 +25
- Misses 1283 1292 +9
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
84132fa
to
95a0454
Compare
@buildpacks/platform-maintainers please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks great, and is a very clean implementation. Could you also merge in the change from #1331 (or just do it by hand), in order to fully bump the Lifecycle version, once it's partially bumped here?
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
adb92bc
to
4187d7b
Compare
@dfreilich done :) - also added some tests for the missing coverage. |
799b0a6
to
bd39ffa
Compare
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
bd39ffa
to
1f855b9
Compare
Link to pack binaries with platform 0.8 support (check artifacts section) https://github.com/buildpacks/pack/actions/runs/1489391193 |
Summary
Adds support for platform api 0.7 and 0.8
Resolves #1333
Resolves #1331