Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for platform api 0.7 and 0.8 #1334

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

sambhav
Copy link
Member

@sambhav sambhav commented Nov 22, 2021

Summary

Adds support for platform api 0.7 and 0.8

Resolves #1333
Resolves #1331

@sambhav sambhav requested a review from a team as a code owner November 22, 2021 00:59
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Nov 22, 2021
@github-actions github-actions bot added this to the 0.23.0 milestone Nov 22, 2021
@sambhav sambhav force-pushed the platform-api branch 6 times, most recently from dd465ab to 84132fa Compare November 22, 2021 01:57
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #1334 (4187d7b) into main (fe92411) will decrease coverage by 0.03%.
The diff coverage is 71.70%.

❗ Current head 4187d7b differs from pull request most recent head 1f855b9. Consider uploading reports for the commit 1f855b9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
- Coverage   80.86%   80.83%   -0.02%     
==========================================
  Files         144      144              
  Lines        9152     9186      +34     
==========================================
+ Hits         7400     7425      +25     
- Misses       1283     1292       +9     
  Partials      469      469              
Flag Coverage Δ
os_linux 79.48% <71.70%> (-0.05%) ⬇️
os_macos 74.12% <71.70%> (+0.04%) ⬆️
os_windows 80.70% <71.70%> (-0.02%) ⬇️
unit 80.83% <71.70%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
@sambhav
Copy link
Member Author

sambhav commented Nov 22, 2021

@buildpacks/platform-maintainers please review :)

Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks great, and is a very clean implementation. Could you also merge in the change from #1331 (or just do it by hand), in order to fully bump the Lifecycle version, once it's partially bumped here?

Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
@sambhav
Copy link
Member Author

sambhav commented Nov 22, 2021

@dfreilich done :) - also added some tests for the missing coverage.

Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
@sambhav
Copy link
Member Author

sambhav commented Nov 22, 2021

Link to pack binaries with platform 0.8 support (check artifacts section) https://github.com/buildpacks/pack/actions/runs/1489391193

@dfreilich dfreilich merged commit a0eac32 into buildpacks:main Nov 22, 2021
@sambhav sambhav deleted the platform-api branch November 22, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for platform 0.7 and 0.8
2 participants