Remove heroku/buildpacks:18 from trusted/suggested builders lists
#1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/chore
The `heroku/buildpacks:18` builder is based upon Heroku-18 / Ubuntu 18.04, which are due to enter their deprecation cycle In the coming April/May. In addition, we currently only run `heroku/buildpacks:20` on the Heroku platform, so whilst this builder does have some rudimentary CI coverage in our builder generation repository (`heroku/pack-images`), the older stack is unused and barely tested in practice. We've recently found a few developers who were inadvertently still using it, since they'd set it as the default builder set some time ago. Lastly, we expected to release a new `heroku/buildpacks:22`builder based on Ubuntu-22 next year, at which point we'd have three builders in the suggested builders list, which seems excessive :-) As such, the older stack has been removed from the trusted and suggested builders list. This is a breaking change for anyone using that image, since they will need to explicitly add it to their trusted builders list (so this will need to be in a new major Pack release). Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
edmorley
force-pushed
the
remove-heroku-buildpacks-18
branch
from
f4f1196
to
b7ea6e7
Compare
sambhav
approved these changes
Dec 21, 2021
dfreilich
approved these changes
Jan 3, 2022
|
No problem at all! Thank you for the review/merge :-) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
heroku/buildpacks:18builder is based upon Heroku-18 / Ubuntu 18.04, which are due to enter their deprecation cycle at Heroku in the coming April/May.In addition, we currently only run
heroku/buildpacks:20on the Heroku platform, so whilst this builder does have some rudimentary CI coverage in our builder generation repository (https://github.com/heroku/pack-images), the older stack is unused and barely tested in practice. We've recently found a few internal developers who were inadvertently still using it, since they'd set it as the default builder some time ago and forgotten in the interim.Lastly, we expected to release a new
heroku/buildpacks:22builder based on Ubuntu-22 next year, at which point we'd have three builders in the suggested builders list, which seems excessive :-)As such, the older stack has been removed from the trusted and suggested builders list. This is a breaking change for anyone using that image, since they will need to explicitly add it to their trusted builders list (so this will need to be in a new major Pack CLI release). However we expect this to affect very few users in practice.
Output
See diff in output excerpt in tests.
Documentation