Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export SBOM during pack build #1359

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

aemengo
Copy link
Contributor

@aemengo aemengo commented Jan 19, 2022

Summary

Export SBOM during pack build, with --sbom-output-dir flag

Output

$ pack build aemengo/hello --sbom-output-dir here
# ...

$ tree here
here
├── build
│   └── aemengo_elm-buildpack
│       └── sbom.cdx.json
├── cache
│   └── aemengo_elm-buildpack
│       └── launch-true-cache-true
│           └── sbom.cdx.json
└── launch
    └── aemengo_elm-buildpack
        ├── launch-only
        │   ├── sbom.cdx.json
        │   └── sbom.syft.json
        ├── launch-true-cache-true
        │   └── sbom.cdx.json
        └── sbom.spdx.json

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No
    • Probably. Not sure yet.

Related

#1335

@fg-j

@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jan 19, 2022
@github-actions github-actions bot added this to the 0.24.0 milestone Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1359 (7833bf0) into main (e38997f) will decrease coverage by 0.06%.
The diff coverage is 55.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
- Coverage   81.53%   81.47%   -0.05%     
==========================================
  Files         148      148              
  Lines        9578     9598      +20     
==========================================
+ Hits         7808     7819      +11     
- Misses       1305     1313       +8     
- Partials      465      466       +1     
Flag Coverage Δ
os_linux 80.20% <55.00%> (-0.05%) ⬇️
os_macos 77.58% <55.00%> (-0.04%) ⬇️
os_windows 81.34% <55.00%> (-0.05%) ⬇️
unit 81.47% <55.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aemengo aemengo force-pushed the export-sbom-during-build branch 2 times, most recently from 9174071 to 44a4978 Compare January 21, 2022 16:00
@aemengo aemengo marked this pull request as ready for review January 21, 2022 18:43
@aemengo aemengo requested a review from a team as a code owner January 21, 2022 18:43
--sbom-output-dir <providied-dir> creates <provided-dir> and exports SBOM created during the build process to <provided-dir>

Signed-off-by: Anthony Emengo <aemengo@vmware.com>
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly for me! Thanks, as always, for the ⭐ contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants