-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ephemeral bridge network name for podman #2241
Conversation
Hmm... the LCOW failures are weird:
Could that really be stemming from |
See #2241 (comment) (this requires further investigation) Signed-off-by: Natalie Arellano <narellano@vmware.com>
Alright, I'm seeing the network error on totally unrelated PRs: https://github.com/buildpacks/pack/actions/runs/10184783472/job/28223468465#step:11:8762 I think something is wrong with our LCOW worker. |
See #2219 (comment) Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
17da6eb
to
b44f845
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 70.03% 70.02% -0.00%
==========================================
Files 254 254
Lines 18670 18673 +3
==========================================
+ Hits 13073 13074 +1
- Misses 4730 4731 +1
- Partials 867 868 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
The LCOW worker was full of ephemeral networks. Likely some containers are still being deleted when we try to delete the network, so I added retries. |
I think the milestone for this PR should be |
See #2219 (comment)