Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ephemeral bridge network name for podman #2241

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano requested review from a team as code owners July 31, 2024 17:20
@github-actions github-actions bot added this to the 0.36.0 milestone Jul 31, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jul 31, 2024
@natalieparellano natalieparellano modified the milestones: 0.36.0, 0.35.1 Jul 31, 2024
@natalieparellano
Copy link
Member Author

Hmm... the LCOW failures are weird:

ERROR: failed to build: executing lifecycle: failed to create ephemeral bridge network: Error response from daemon: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network

Could that really be stemming from / vs -?

@github-actions github-actions bot modified the milestones: 0.35.1, 0.36.0 Jul 31, 2024
natalieparellano added a commit that referenced this pull request Aug 1, 2024
See #2241 (comment) (this requires further investigation)

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

Alright, I'm seeing the network error on totally unrelated PRs: https://github.com/buildpacks/pack/actions/runs/10184783472/job/28223468465#step:11:8762

I think something is wrong with our LCOW worker.

See #2219 (comment)

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.02%. Comparing base (5d0687f) to head (b44f845).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   70.03%   70.02%   -0.00%     
==========================================
  Files         254      254              
  Lines       18670    18673       +3     
==========================================
+ Hits        13073    13074       +1     
- Misses       4730     4731       +1     
- Partials      867      868       +1     
Flag Coverage Δ
os_linux 69.16% <66.67%> (-0.02%) ⬇️
os_macos-arm64 65.34% <66.67%> (-<0.01%) ⬇️
os_windows 69.55% <66.67%> (+0.70%) ⬆️
unit 70.02% <66.67%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natalieparellano
Copy link
Member Author

The LCOW worker was full of ephemeral networks. Likely some containers are still being deleted when we try to delete the network, so I added retries.

@natalieparellano natalieparellano merged commit 3a22a7f into main Aug 5, 2024
18 checks passed
@natalieparellano natalieparellano deleted the fix/network-name branch August 5, 2024 16:02
@edmorley
Copy link
Contributor

edmorley commented Aug 5, 2024

I think the milestone for this PR should be 0.35.1 rather than 0.36.0, since it made the release:
v0.35.0...v0.35.1

@natalieparellano natalieparellano modified the milestones: 0.36.0, 0.35.1 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants