-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNB_BUILDPACK_DIR environment variable #71
Conversation
Signed-off-by: Manuel Fuchs <malax@malax.de>
1387b17
to
d050b57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I've seen a bunch of buildpacks do at Heroku. I'm curious of on the VMware/Pivotal side this is as common?
This is also common on the CF side. My only request before approving would be that the env var be We also may want to consider why an env var might be appropriate here vs. a positional arg like the other input directories. |
Signed-off-by: Manuel Fuchs <malax@malax.de>
166bd7f
to
1211997
Compare
@sclevine I renamed the variable, thanks! :)
I touched on that a little bit in the RFC, assuming we want to keep the amount of positional arguments low. It's harder to remember the order of argument than an actual name. That would be true for all other arguments though. What was the deciding factor to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to abstain from this RFC.
We should make the RFC decision here independent of the positional argument/env var discussion IMO. Cleaning that up should be a separate RFC. |
In FCP as of 4/15 |
Readable