Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Process specific environment variables #72

Closed
wants to merge 1 commit into from

Conversation

dsyer
Copy link

@dsyer dsyer commented Apr 3, 2020

No description provided.

@dsyer dsyer requested a review from a team as a code owner April 3, 2020 11:42
@nebhale
Copy link
Contributor

nebhale commented Apr 9, 2020

@dsyer Can you please put some concrete examples (existing buildpacks or example commands) of situations where the current system isn't sufficient.

@dsyer
Copy link
Author

dsyer commented Apr 23, 2020

The example I was working on was a Spring Boot app. In the default "web" profile, it just runs the app. In the "foo" profile it exposes the Prometheus endpoint for collecting metrics. Another profile might run the database migration scripts. Each one requires different environment variables, and env vars from one profile might pollute or interfere with another. E.g. if I'm not running db migrations I don't need the db admin password.

@hone
Copy link
Member

hone commented May 13, 2020

From last week, @sclevine will create a new RFC based on this work.

@sclevine sclevine marked this pull request as draft May 27, 2020 19:14
@sclevine
Copy link
Member

Converting this to a draft for now. I plan to pick it up eventually.

@hone
Copy link
Member

hone commented May 29, 2020

@jabrown85 identified a great use case for this and is going to pick this up.

@jabrown85
Copy link
Contributor

I opened a new PR here to continue this discussion further.

@hone
Copy link
Member

hone commented Jun 1, 2020

With #83, I motion for this to be closed.

@sclevine sclevine closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants