Increase Build Plan Flexibility #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Hale <bhale@vmware.com>
jkutner
approved these changes
Jun 2, 2020
ekcasey
approved these changes
Jun 3, 2020
jromero
approved these changes
Jun 3, 2020
|
I think there's probably a way we can make it interoperate with the old plan. We could in the new world autocreate a |
sclevine
reviewed
Jun 3, 2020
sclevine
approved these changes
Jun 4, 2020
This change adds a statement about the lifecycle ensuring compatibility. Signed-off-by: Ben Hale <bhale@vmware.com>
This change adds a statement about the change to the BOM schema to demote the version key to match the buildpack plan. Signed-off-by: Ben Hale <bhale@vmware.com>
nebhale
added a commit
to buildpacks/libcnb
that referenced
this pull request
Jun 5, 2020
This change updates the library to remove the version field from the build plan and buildpack plan in preparation for buildpacks/rfcs#82. Signed-off-by: Ben Hale <bhale@vmware.com>
nebhale
added a commit
to paketo-buildpacks/libpak
that referenced
this pull request
Jun 5, 2020
This change updates the library to remove the version field from the build plan and buildpack plan in preparation for buildpacks/rfcs#82. Signed-off-by: Ben Hale <bhale@vmware.com>
|
I'd love to get some input from buildpack authors like those from the Paketo team (@dwillist), Google (@dgageot @lukasberger), and Heroku (@danielleadams @Malax) at least since this impacts you the most. |
hone
reviewed
Jun 10, 2020
Signed-off-by: Ben Hale <bhale@vmware.com>
|
Final Comment Period with merge disposition, closing on 17 June, 2020. |
|
Looked over this and discussed it with @hone. The Heroku buildpacks aren't using |
hone
reviewed
Jun 16, 2020
hone
approved these changes
Jun 16, 2020
Signed-off-by: Ben Hale <bhale@vmware.com> Co-authored-by: Terence Lee <hone02@gmail.com>
nebhale
added a commit
to buildpacks/spec
that referenced
this pull request
Jun 24, 2020
This change implements the updates from buildpacks/rfcs#82. [resolves #91] Signed-off-by: Ben Hale <bhale@vmware.com>
nebhale
added a commit
to buildpacks/spec
that referenced
this pull request
Jun 25, 2020
This change implements the updates from buildpacks/rfcs#82. [resolves #91] Signed-off-by: Ben Hale <bhale@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readable