RFC: Override Env Vars By Default #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
edmorley
reviewed
Jul 27, 2020
Signed-off-by: Stephen Levine <stephen.levine@gmail.com> Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
ekcasey
approved these changes
Jul 27, 2020
nebhale
approved these changes
Jul 27, 2020
edmorley
reviewed
Jul 27, 2020
Signed-off-by: Stephen Levine <stephen.levine@gmail.com> Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
jromero
approved these changes
Jul 27, 2020
jabrown85
approved these changes
Jul 29, 2020
jkutner
approved these changes
Jul 30, 2020
|
Final Comment Period with merge disposition, closing on 10 August, 2020. |
dfreilich
reviewed
Aug 5, 2020
| # What it is | ||
| [what-it-is]: #what-it-is | ||
|
|
||
| Buildpack authors can create environment variable files as `<layer>/env(.launch|.build|)/NAME` such the an environment variable with name `NAME` is exported into the runtime, build-time (for subsequent buildpacks), or both environments. The contents of the file are set as the value. |
There was a problem hiding this comment.
Suggested change
| Buildpack authors can create environment variable files as `<layer>/env(.launch|.build|)/NAME` such the an environment variable with name `NAME` is exported into the runtime, build-time (for subsequent buildpacks), or both environments. The contents of the file are set as the value. | |
| Buildpack authors can create environment variable files as `<layer>/env(.launch|.build|)/NAME` such that an environment variable with name `NAME` is exported into the runtime, build-time (for subsequent buildpacks), or both environments. The contents of the file are set as the value. |
|
|
||
| Buildpack authors can create environment variable files as `<layer>/env(.launch|.build|)/NAME` such the an environment variable with name `NAME` is exported into the runtime, build-time (for subsequent buildpacks), or both environments. The contents of the file are set as the value. | ||
|
|
||
| These environment variable files are applied dynamically, either before subsequent buildpacks or when the app container starts. Their application may be modulated by file extensions such as `.append`, `.prepend`, `.default`, and `.override`. For `.append` and `.prepend`, a special `NAME.delim` file may be used to specify the delimiter. |
There was a problem hiding this comment.
To clarify – if you wanted to append to PATH, you would create a file <layer>/env(.launch|.build|)/NAME.append?
|
Overall, we should make this change but the devil is in handling the backwards breaking changes. I assume this is slated for 1.0. Do we plan to handle the current behavior and this behavior in the same group? |
|
@hone If we can find a comfortable way to do it, I would say yes. Some options might be:
I think I like 2 best, but it feels like we've got some options to play around with that should give us the compatibility we desire. |
I think @ekcasey had plans to do this already. |
nebhale
added a commit
that referenced
this pull request
Aug 11, 2020
This was referenced Aug 17, 2020
nebhale
added a commit
to buildpacks/libcnb
that referenced
this pull request
Sep 10, 2020
Given an upcoming spec change around how environment variables are written to the filesystem, this change updates the API to be compatible with both old and new versions. It does this by eliminating the "unqualified" API and requiring explicit declarations for all API usage. It also eliminates the "delimiter" APIs in favor of requiring a delimiter for all "append" and "prepend" APIs. [buildpacks/spec#131][buildpacks/rfcs#98] Signed-off-by: Ben Hale <bhale@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readable