Simplify condition to deploy on main #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the syntax from the Github Actions documentation https://docs.github.com/en/actions/learn-github-actions/expressions Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
sambhav
reviewed
Mar 31, 2023
| @@ -42,12 +42,12 @@ jobs: | |||
| - name: Build | |||
| run: PACK_CMD=./pack make build-linux build-wine | |||
| - uses: azure/docker-login@v1 | |||
| if: (github.event_name == 'repository_dispatch') || (github.event_name == 'push' && github.ref == 'refs/heads/main') | |||
There was a problem hiding this comment.
AFAIK this step should run only on the main branch. The workflow is executed on repository_dispatch, but I believe the step should only run on the main branch.
|
Do we know why CircleCI is failing with |
|
We have not sucessfully published a :jammy image yet, because the GH
workflow keeps skipping the deploy step. Hence, in this PR, we're
simplifying the condition.
…On Mon, 3 Apr 2023, 16:37 Natalie Arellano, ***@***.***> wrote:
Do we know why CircleCI is failing with ERROR: failed to build: failed to
fetch builder image 'index.docker.io/cnbs/sample-builder:jammy': image '
index.docker.io/cnbs/sample-builder:jammy' does not exist on the daemon:
not found?
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADHKU55JOYG2GYYD7LRAFTW7LVDJANCNFSM6AAAAAAWOIBVB4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sambhav
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the syntax from the Github Actions documentation
https://docs.github.com/en/actions/learn-github-actions/expressions