Updates platform spec to improve performance when restoring launch sboms from daemon #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oms from daemon Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
sbom-fix
branch
from
8cccad1
to
d0aaf31
Compare
hone
approved these changes
Dec 15, 2021
nebhale
approved these changes
Jan 5, 2022
jkutner
approved these changes
Jan 5, 2022
ekcasey
reviewed
Jan 13, 2022
| | `<log-level>` | `CNB_LOG_LEVEL` | `info` | Log Level | ||
| | `<previous-image>`| `CNB_PREVIOUS_IMAGE` | `<image>` | Image reference to be analyzed (usually the result of the previous build) | ||
| | `<run-image>` | `CNB_RUN_IMAGE` | resolved from `<stack>` | Run image reference | ||
| | `<skip-layers>` | `CNB_SKIP_LAYERS` | `false` | Do not restore SBOM layer from previous image |
There was a problem hiding this comment.
Why do we split this across two phases?
- Restoring the sbom directory during
analyze - Copying sbom files to layers directories and then deleting sbom directory during
restore
Wouldn't it be cleaner just to do everything during the restore phase so that the exact steps (restore, copy, delete) can be implementation details rather that specified behavior. Also, restorer already receives the skip-layers flag, so we would only need to add a single flag -launch-cache to the restore phase.
There was a problem hiding this comment.
We were torn between these two options (see #276 (comment)). Having restore do everything would require additional logic to provide the -daemon flag, mount in the daemon socket, and run as root.
ekcasey
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276 (went with Option 1)