date_and_time_field partial handles no timezone set on team #830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started happening when I updated to tag v1.7.4
If there is no timezone set on a Team (my
db:reset
did not set one by default) then checkingActiveSupport::TimeZone.find_tzinfo(current_team_time_zone)
fails withTrace:
Also, I don't see where
user_tz
is being used, but we do things like<% if current_user&.time_zone != current_team_time_zone %>
when that should maybe be theuser_tz
calculated above. (I didn't know if that's part of this issue or not and I don't have time to dig in more now.)