Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date_and_time_field partial handles no timezone set on team #830

Merged
merged 1 commit into from
May 20, 2024

Conversation

wesgarrison
Copy link
Contributor

This started happening when I updated to tag v1.7.4

If there is no timezone set on a Team (my db:reset did not set one by default) then checking ActiveSupport::TimeZone.find_tzinfo(current_team_time_zone) fails with

TZInfo::InvalidTimezoneIdentifier at /account/model/:id/new 
Invalid identifier: nil

Trace:
image

Also, I don't see where user_tz is being used, but we do things like <% if current_user&.time_zone != current_team_time_zone %> when that should maybe be the user_tz calculated above. (I didn't know if that's part of this issue or not and I don't have time to dig in more now.)

Copy link
Contributor

@jagthedrummer jagthedrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wesgarrison. The test failures here are related to the fact that we recently updated the starter repo to use yarn version 4. I've address that problem for the core repo here: #832

I'm gonna go ahead and merge this and will watch CI on main.

@jagthedrummer jagthedrummer merged commit b37fbe1 into bullet-train-co:main May 20, 2024
19 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants