Novo 7 upgrade new #8
Conversation
| import {Configuration} from './settings.types'; | ||
|
|
||
| @Injectable() | ||
| export class SettingsService { |
There was a problem hiding this comment.
Remove SettingsService as this is internal. Also remove the "settingsConfig" object from the environment files (all of them).
src/app/app.module.ts
Outdated
| ], | ||
| providers: [ | ||
| AppBridgeService | ||
| AppBridgeService, | ||
| SettingsService |
There was a problem hiding this comment.
Spoke with Tomas. We do not need the SettingsService included in the Open Source Repo
| @@ -48,6 +48,7 @@ export class AppBridgeService { | |||
| } | |||
|
|
|||
| private register() { | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
What are we ignoring for this?
There was a problem hiding this comment.
This must be ignoring the type error raised for the register parameter type, which changed slightly - There's a property in the param type named color that used to be a string and now is a AlleyLinkColor (Which is a subset of strings). The color property in the environment.appBridgeConfig object could be cast to AlleyLinkColor, too, which would get rid of the ts error.
cc: @BantiG
| "buildOptimizer": false, | ||
| "sourceMap": true, | ||
| "optimization": false, | ||
| "namedChunks": true | ||
| }, | ||
| "configurations": { |
There was a problem hiding this comment.
Can't comment on the right line because it wasn't changed...but under the staging/local configurations, I would recommend adding
"sourceMap": true, "optimization": false,
at the same level as the fileReplacements property. From what I've seen this allows you to get the source maps and like properly debug
angular.json
Outdated
| }, | ||
| "configurations": { | ||
| "prod": { | ||
| "optimization": true, | ||
| "optimization": false, |
There was a problem hiding this comment.
We don't want to do this for the prod configuration. We want this for the staging and local config. This would just make the production environment slower, which we don't want.
BantiG
force-pushed
the
novo-7-upgrade-new
branch
from
c54d13f
to
1574953
Compare
No description provided.