Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Search): adding ability to override parent element for custom overlay positioning #1559

Merged
merged 3 commits into from
Jun 28, 2024
Merged

feat(Search): adding ability to override parent element for custom overlay positioning #1559

merged 3 commits into from
Jun 28, 2024

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Jun 20, 2024 •
edited
Loading

Description

this way we can attach the overlay to any element we want.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@dvoegelin dvoegelin self-assigned this Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 00b267b):

https://novo-elements--pr1559-search-parent-bjh347kh.web.app

(expires Thu, 04 Jul 2024 18:27:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

davidkbh
davidkbh previously approved these changes Jun 21, 2024
View reviewed changes
@dvoegelin dvoegelin merged commit 5ebf232 into next Jun 28, 2024
5 checks passed
@dvoegelin dvoegelin deleted the search-parent branch June 28, 2024 16:35
@dvoegelin dvoegelin mentioned this pull request Jun 28, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkbh davidkbh davidkbh approved these changes

@monroepe monroepe monroepe approved these changes

Assignees

@dvoegelin dvoegelin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvoegelin @monroepe @davidkbh