Add ability to define node customisation lazily #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LachlanMcKee
force-pushed
the
allow-customisation-to-be-lazy
branch
from
c9c6644
to
be8ec13
Compare
LachlanMcKee
force-pushed
the
allow-customisation-to-be-lazy
branch
2 times, most recently
from
091a948
to
4da9474
Compare
zsoltk
approved these changes
Apr 4, 2023
CherryPerry
reviewed
Apr 4, 2023
...c/main/kotlin/com/bumble/appyx/utils/customisations/LazyMutableNodeCustomisationDirectory.kt
Show resolved
Hide resolved
...c/main/kotlin/com/bumble/appyx/utils/customisations/LazyMutableNodeCustomisationDirectory.kt
Show resolved
Hide resolved
...ions/src/main/kotlin/com/bumble/appyx/utils/customisations/NodeCustomisationDirectoryImpl.kt
Outdated
Show resolved
Hide resolved
LachlanMcKee
force-pushed
the
allow-customisation-to-be-lazy
branch
from
4da9474
to
37e1bdc
Compare
KovalevAndrey
approved these changes
Apr 4, 2023
CherryPerry
approved these changes
Apr 4, 2023
LachlanMcKee
force-pushed
the
allow-customisation-to-be-lazy
branch
from
37e1bdc
to
0eeb5e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it is not possible to define a node customisation lazily which means that potentially a large amount of classes are instantiated when they are not needed.
This PR aims to add a new API that allows this to be done lazily.
Check list
CHANGELOG.mdif required.