api(bump): 'id' attribute is always present in both previews & versions responses #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There no need to define an optional ID in the /versions API response because if the HTTP status is ok we guarantee that its there. This avoid adding extra defensive code in the CLI which will never be reached.
thimy
approved these changes
Jun 18, 2021
|
Thanks for the review 🙇! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tells the TS compiler that the Bump API will always answer with an
idfield in the responses for both POST /versions & POST /previews.It doesn't change anything feature wise but will avoid useless JS guards when using those fields.