Feat new python versions #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wirthual
commented
Jul 29, 2022
•
wirthual
commented
- Fixed typo in readme
- Set protobuf to lower version to avoid installation error (Can't get 0.3.0 running #65 )
- Updated lock
- Use latest available patch per python version
- Update github action name for docs
jugmac00
reviewed
Jul 29, 2022
.github/workflows/runtests.yml
Outdated
| @@ -7,7 +7,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.6.7","3.7", "3.8", "3.9"] | |||
| python-version: ["3.9.13","3.9.10","3.9.6","3.9.5","3.9.4","3.9.3","3.9.1","3.9.0","3.8.13","3.8.12","3.8.10","3.8.9","3.8.8","3.8.7","3.8.6","3.8.5","3.8.3","3.8.2","3.8.1","3.8.0","3.7.13","3.7.12","3.7.11","3.7.9","3.7.8","3.7.6","3.7.5","3.7.1","3.6.12","3.6.11","3.6.10","3.6.9"] | |||
There was a problem hiding this comment.
It is not necessary to test Python versions on a patch level.
This gives basically nothing, but only increases the test time and also the resource consumption.
There was a problem hiding this comment.
I agree, testing patches is not really necessary
There was a problem hiding this comment.
Makes sense. Will keep the latest patch for each minor version 👍
lukaspanni
suggested changes
Jul 29, 2022
This reverts commit fed57de.
…e setup python to v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.