This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Implement to_ary
to avoid calls to method_missing
#1274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code is calls method missing and emits annoying warnings when -d is used:
We can silence these warnings by implementing a
to_ary
that returns nil:According to ruby spec it's OK for
to_ary
to return nil, and it will just be ignored. We can also see that the ruby implementation agrees.This patch adds
to_ary
for two reasons:Thanks!