Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show skipped items at the end of the apply #757

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Kunsi
Copy link
Contributor

@Kunsi Kunsi commented May 13, 2024

This fixes #514 by showing a summary of skipped items at the end for all items that provide a more detailed description of the reason they were skipped.

This was implemented by allowing an item to return a tuple for details in Item.apply(), of which the first value is the technical reason, the second value is the text message that gets shown to the user. For FaultUnavailable, we just show the exception message.

screenshot_2024-05-13_053426

Kunsi added 2 commits May 13, 2024 05:57
This prints all the items that provided a detailed error message at the
end of the apply, so users are able to see which items were skipped because
of (for example) missing faults.

This fixes bundlewrap#514
@fkusei
Copy link
Contributor

fkusei commented May 13, 2024

Immediate Reactions:

  • Why are skipped items now shown above and below the summary?
  • "Fault unavailable" during the apply should show the reason as well
  • Should "Fault unavailable" be an error and thus show up in error_summary() and/or change the exitcode?

@vain
Copy link
Member

vain commented Oct 24, 2024

Another question: Why only show skipped items? Failed items can be hard to spot as well, if the output is long enough.

This is a tough one. We have to try to keep/make the output clean and concise, and at the same time informative … Maybe ban some of the output to a log file? 🫤

@vain
Copy link
Member

vain commented Oct 24, 2024

Personally, what I do is search the terminal history for or ». Typing those symbols can be challenging, though. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply: Unavailable Faults should indicate “why” they are unavailable
3 participants