show skipped items at the end of the apply #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kunsi
force-pushed
the
handle_skipped_items
branch
from
f7d7dbe
to
003c3d0
Compare
This prints all the items that provided a detailed error message at the end of the apply, so users are able to see which items were skipped because of (for example) missing faults. This fixes bundlewrap#514
Kunsi
force-pushed
the
handle_skipped_items
branch
from
003c3d0
to
39b0117
Compare
|
Immediate Reactions:
|
|
Another question: Why only show skipped items? Failed items can be hard to spot as well, if the output is long enough. This is a tough one. We have to try to keep/make the output clean and concise, and at the same time informative … Maybe ban some of the output to a log file? 🫤 |
|
Personally, what I do is search the terminal history for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #514 by showing a summary of skipped items at the end for all items that provide a more detailed description of the reason they were skipped.
This was implemented by allowing an item to return a tuple for
detailsinItem.apply(), of which the first value is the technical reason, the second value is the text message that gets shown to the user. ForFaultUnavailable, we just show the exception message.