Shmem4: a set of small fixes to shmem implementation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update. and if the update fails in the UPDATING state, move back to READY, instead of trying to synchronize with readers and COPY the data. in case diff-based update fails at the last stage (which invalidates the zone followed by full reload), it would be better to let the readers keep using the current version until the next load happens.
so it can benefit from the previous commit: moving back to READY from UPDATING when loading fails.
change is trivial, so adjusting the test should be enough.
this situation should be rare, but when it happens the zone data is detached from the zone table and forgotten.
this way we can complete using the journal (possibly with DB transaction) in the load() phase for typical DDNS cases, reducing the risk of failure in the commit() phase, which is more expensive.
previously it tries to load zone data while holding the lock, and the loading can be a very time consuing task, so it's not good.
as it can be too noisy with a busy DDNS server.
jinmei
added a commit
that referenced
this pull request
Jun 12, 2014
Shmem4: a set of small fixes to shmem implementation
|
merging, and opening a new issue for the outstanding review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of small fixes and improvements of the shared memory/mmap support.
Other than trivial one-liner fixes, there are two major changes: