shmem/mmap support: handle full datasrc reconfig #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on second thought, it seems sufficient to only work on the current data src info for the case of data source reconfiguration.
this simplifies the main cases as we can assume there's at least one generation of data sources.
this seems to be convenient for expected usage later.
… ack. that's possible depending on the timing. helper function isn't needed anymore so removed.
this is a necessary cleanup on migrating a generation of data sources to another.
…d reader this should complete the memmgr side of data source reconfiguration.
not just "classes", but also "_generation_id". (the latter is not yet used for now).
…g sgmt. we'll store them in a placeholder structure until all segments are ready (not done in this commit). also retrieve the gen ID from the passed config.
…hes. and also perform swap if the pending data are ready as a result of the update.
also corrected typo in the builder side.
also added some test cases and a log message.
also, generalized the name of 'reconfigureDone' so it can be used for other purposes (specifically for release_segment).
…ment. not really used it except for tests.
to determine whether to subscribe/unsubscribe the SegmentReader group. checking the running config does not work anymore because we now don't start using a new generation of config until all waiting segments are reset (besides, hardcoding "mapped" type was not really good as there could be other shared-type of memory segments).
so each command handle can control whether/which callbacks should be called when more freely. this will be needed for release_segments commands. also, a minimum framework for release_segments was added.
this should complete the support for datasrc reconfig with memory segments in bundy-auth.
|
merging, will create a separate issue for the outstanding review. |
jinmei
added a commit
that referenced
this pull request
Jun 18, 2014
shmem/mmap support: handle full datasrc reconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes update bundy-memmgr and bundy-auth so they can handle full reconfiguration of data sources (the data_sources configuration item).
The first half of the changes are for memmgr (up to commit 9864dfa), and the rest is for auth. These are independent and can be reviewed separately, but the entire set of changes will be needed for the system to work correctly.