Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bunq SDK needs two minor refactors #11

Closed
dnl-blkv opened this issue Aug 21, 2017 · 0 comments
Closed

Bunq SDK needs two minor refactors #11

dnl-blkv opened this issue Aug 21, 2017 · 0 comments
Assignees
@dnl-blkv
Labels
enhancement
Milestone
v0.10.0

Comments

@dnl-blkv
Copy link
Contributor

How to Reproduce

  1. Observe code of InstallationConverter
  2. Observer code of BunqModel

What Should Happen

  1. InstallationConverter is consistent with SessionServerConverter
  2. BunqModel is clean and well-factored

What Happens

  1. InstallationConverter is inconsistent with SessionServerConverter
  2. BunqModel has a magic number
@dnl-blkv dnl-blkv added this to the v0.10.0 milestone Aug 21, 2017
@dnl-blkv dnl-blkv self-assigned this Aug 21, 2017
dnl-blkv added a commit that referenced this issue Aug 21, 2017
@dnl-blkv
cleanup C# SDK [#11]
940ea04
@dnl-blkv dnl-blkv mentioned this issue Aug 21, 2017
Merged
OGKevin added a commit that referenced this issue Aug 21, 2017
@OGKevin
Merge pull request #12 from bunq/11-cleanup
02bcaa5 
cleanup C# SDK [#11]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnl-blkv dnl-blkv

Labels
enhancement
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
1 participant
@dnl-blkv