Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure received signatures headers are correctly cased #49

Closed
OGKevin opened this issue Nov 28, 2017 · 0 comments
Closed

Make sure received signatures headers are correctly cased #49

OGKevin opened this issue Nov 28, 2017 · 0 comments
Assignees
@OGKevin
Labels
enhancement
Milestone
0.12.4

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Nov 28, 2017

Steps to reproduce:

  1. Receive a response from the API
  2. The response headers are lowercased.
  3. Try and verify the signature

What should happen:

  1. The signature is verified correctly

What happens:

  1. The signature verification will fail

Logs

  • Logs no logs

Extra info:

Reference
@OGKevin OGKevin added this to the 0.12.5 milestone Nov 28, 2017
@OGKevin OGKevin self-assigned this Nov 28, 2017
@OGKevin OGKevin modified the milestones: 0.12.5, 0.12.4 Dec 21, 2017
OGKevin added a commit that referenced this issue Dec 21, 2017
@OGKevin
Insure that headers are correclty cased before signature verification. (
6c97a23 
#49)
@OGKevin OGKevin mentioned this issue Dec 21, 2017
Merged
OGKevin added a commit that referenced this issue Dec 21, 2017
@OGKevin
Adde constant for magic value. (#49)
f7155de
OGKevin added a commit that referenced this issue Dec 21, 2017
@OGKevin
Fixed typo in GetHeaderNameCorrectlyCased. (#49)
2944f3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
0.12.4
Development

No branches or pull requests
1 participant
@OGKevin