Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response id to error messages from failed requests  #63

Closed
OGKevin opened this issue Dec 24, 2017 · 2 comments
Closed

Add response id to error messages from failed requests  #63

OGKevin opened this issue Dec 24, 2017 · 2 comments
Assignees
@OGKevin
Labels
enhancement
Milestone
0.12.5

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Dec 24, 2017

Steps to reproduce:

  1. Make a bad request
  2. Try and get the response id from the X-Bunq-Server-Response-Id header.

What should happen:

  1. There is a way to get the response id to debug this error on bunq's side if needed.

What happens:

  1. 👆 is not possible.

Logs

  • Logs 'no logs

Extra info:

References
@OGKevin OGKevin added this to the 0.12.5 milestone Dec 24, 2017
@OGKevin OGKevin self-assigned this Dec 24, 2017
@kid-cavaquinho
Copy link

@OGKevin the X-Bunq-Server-Response-Id header is always present in every request, correct? Should it only be returned with 400 messages?

@OGKevin
Copy link
Contributor Author

OGKevin commented Dec 28, 2017 •
edited
Loading

@AnTao it is indeed present with each request!

Please see how its implemented in php: bunq/sdk_php#93 or by viewing the referenced issue 👍 So you have an idea on how it should be done.

OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Added error and response header constants. (#63)
9f97ff0
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Added method to extract response id. (#63)
779497a
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Added response id field to base exception class. (#63)
5428670
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Refactored the classes that extend ApiException to support the new ba…
0ef56e2 
…se class. (#63)
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Refactored exception factory to use the response id. (#63)
c458fe3
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Pass the response id to exception factory from ApiClient on failed re…
0d32d52 
…quests. (#63)
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Added test to ensure that the response id is populated with data. (#63)
d3d5c55
@OGKevin OGKevin mentioned this issue Dec 30, 2017
Merged
1 task
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Made INVALID_USER_PERSON_ID a constant. (#63)
c7fc372
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Fixed invalid string format. (#63)
8eb6321
OGKevin added a commit that referenced this issue Dec 31, 2017
@OGKevin
Fixed typos in ResponseId. (#63)
66687f7
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Use assert throws in test. (#63)
cc2f0a8
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Fixed indentions. (#63)
013678d
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Use build in new line separator. (#63)
917d984
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Changed some method signatures for cleaner code. (#63)
3dab5f9
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Changed Ilist to IEnumerable. (#63)
b855651
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added error and response header constants. (#63)
2fcf849
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added method to extract response id. (#63)
811b35d
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added response id field to base exception class. (#63)
aff6b20
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Refactored the classes that extend ApiException to support the new ba…
03912ab 
…se class. (#63)
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Refactored exception factory to use the response id. (#63)
60e18a5
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Pass the response id to exception factory from ApiClient on failed re…
e775766 
…quests. (#63)
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added test to ensure that the response id is populated with data. (#63)
6eddd49
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Made INVALID_USER_PERSON_ID a constant. (#63)
961715a
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Fixed invalid string format. (#63)
4a42f7d
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Fixed typos in ResponseId. (#63)
e59fcf3
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Use assert throws in test. (#63)
3d9c9de
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Fixed indentions. (#63)
3d7bb5e
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Use build in new line separator. (#63)
3698815
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Changed some method signatures for cleaner code. (#63)
7429ce0
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Changed Ilist to IEnumerable. (#63)
7cb55ae
andrederoos added a commit that referenced this issue Jan 2, 2018
@andrederoos
Merge branch 'develop' into #63-add-response-id-to-failed-request
29daba5
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Added missing else and moved else if statement to new line. (#63)
e88274c
andrederoos added a commit that referenced this issue Jan 2, 2018
@andrederoos
Merge branch 'develop' into #63-add-response-id-to-failed-request
5a2a805
OGKevin added a commit that referenced this issue Jan 3, 2018
@OGKevin
Merge pull request #73 from bunq/#63-add-response-id-to-failed-request
fbbd9ad 
(#63) add response id to failed request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
0.12.5
Development

No branches or pull requests
2 participants
@kid-cavaquinho @OGKevin