Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NotificationFilter, Serialization issues and implement PSD2 #128

Merged
merged 7 commits into from
Sep 10, 2019
Merged

Fix NotificationFilter, Serialization issues and implement PSD2 #128

merged 7 commits into from
Sep 10, 2019

Conversation

FNG21
Copy link
Contributor

@FNG21 FNG21 commented Sep 4, 2019

This PR closes/fixes the following issues:

@FNG21 FNG21 changed the title Feature/sdk csharp psd2 examples Fix NotificationFilter, Serialization issues and implement PSD2 Sep 4, 2019
andrederoos
andrederoos requested changes Sep 9, 2019
View reviewed changes
BunqSdk/Model/Core/NotificationFilterPushUserInternal.cs Outdated

return FromJsonList<NotificationFilterPush>(responseRaw, OBJECT_TYPE_GET);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty lines

BunqSdk/Model/Core/NotificationFilterUrlUserInternal.cs Outdated
Dictionary<string, object> requestMap = new Dictionary<string, object>();
requestMap.Add(FIELD_NOTIFICATION_FILTERS, allNotificationFilter);


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

BunqSdk/Model/Core/NotificationFilterUrlUserInternal.cs Outdated

return FromJsonList<NotificationFilterUrl>(responseRaw, OBJECT_TYPE_GET);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty lines

@andrederoos andrederoos merged commit 2fd8a04 into develop Sep 10, 2019
@andrederoos andrederoos deleted the feature/sdk_csharp-psd2-examples branch September 10, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrederoos andrederoos andrederoos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@FNG21 @andrederoos @nickvandegroes