add proxy support, make httpClient instance variable [#15] #16
Conversation
|
@OGKevin Had to make HttpClient an instance variable for a case if they want to use two different contexts with two different proxies within one process :) |
|
|
||
| private HttpClientHandler CreateHttpClientHandler() | ||
| { | ||
| // TODO: Add HTTP Public Key Pinning. It is needed to prevent possible man-in-the-middle attacks using |
There was a problem hiding this comment.
Is this TODO supposed to be here ? If so could you remove it and create an issue for it with a link to this particular file and line ?
There was a problem hiding this comment.
This TODO is supposed to be there, and we would like to keep it there as TODO. Issue can be created additionally (you can do it if you wish :P).
|
|
||
| public bool IsBypassed(Uri host) | ||
| { | ||
| return false; /* Proxy all requests */ |
There was a problem hiding this comment.
Nope, because this refers to the documentation. false means "Nothing is bypassed" which means "proxy all requests".
| public BunqProxy(string proxyUri) | ||
| : this(new Uri(proxyUri)) | ||
| { | ||
| } |
There was a problem hiding this comment.
Is there really a need for 2 lines for this 😝 can this be reformatted ?
There was a problem hiding this comment.
@OGKevin this is in accordance with C# coding standard
No description provided.