Add pagination; add missing fields and objects [#17] #18
Conversation
|
@OGKevin when you're done with reviewing, please poke me but don't merge yet! :) |
BunqSdk/Http/Pagination.cs
Outdated
| "Could not generate previous page URL params: there is no previous page."; | ||
|
|
||
| /// <summary> | ||
| /// URL Param constants. |
There was a problem hiding this comment.
Ok I triple checked this time haha, not generated right 😝. Below you have param without capital P so I guess this one should also be lower case ?
There was a problem hiding this comment.
Ohh OCD! :D I'll fix this :)
BunqSdk/Json/PaginationConverter.cs
Outdated
| private const int INDEX_PARAM_VALUE = 1; | ||
|
|
||
| /// <summary> | ||
| /// Base dummy URL to hack though the incomplete relative URI functionality of dotnetcore. |
There was a problem hiding this comment.
Is though a typo ? Shouldn't it be through. And this is kinda clever btw 👏
There was a problem hiding this comment.
That's indeed a typo! Thanks :)
|
@dnl-blkv tests passing. please add pagination tests as we discussed and address the changes I proposed and it should be good to merge. |
|
Cleanups done, Pagination test to go! |
|
All tests passing, LGTM. @andrederoos please take a look 👀. |
No description provided.