Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/is session active#33 #34

Merged
merged 3 commits into from
Oct 24, 2017
Merged

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Oct 20, 2017

Context

#33

What has been done

This pr introduces a new way to handle SessionContext. Now it is possible to do the following:

if (!apiContext.IsSessionActive()) {
    apiContext.ResetSession();
    apiContext.Save();
}

This way there is no saving an unchanged context.

Closes #33

@OGKevin OGKevin self-assigned this Oct 20, 2017
@OGKevin OGKevin requested a review from dnl-blkv October 20, 2017 08:10
Copy link
Contributor

@dnl-blkv dnl-blkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dnl-blkv dnl-blkv merged commit 19200fa into develop Oct 24, 2017
@dnl-blkv
Copy link
Contributor

@andrederoos

@dnl-blkv dnl-blkv deleted the feature/isSessionActive#33 branch October 24, 2017 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants