Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strictly typed BunqResponses #27

Closed
dnl-blkv opened this issue Sep 23, 2017 · 1 comment
Closed

Add strictly typed BunqResponses #27

dnl-blkv opened this issue Sep 23, 2017 · 1 comment
Assignees
@dnl-blkv
Labels
enhancement
Milestone
v0.12.0

Comments

@dnl-blkv
Copy link
Contributor

How to Reproduce

  1. Write code to make a request via the SDK
  2. Write a code using the response of the request from (1)

What Should Happen

  1. The response.value has a strict type in docstring, and the IDE auto-completion works on it

What Happens

  1. The response.value doesn't have a strict type in docstring and therefore IDE auto-completion doesn't work on it
@dnl-blkv dnl-blkv self-assigned this Sep 23, 2017
dnl-blkv added a commit that referenced this issue Sep 23, 2017
@dnl-blkv
Add strictly typed responses; fix circular dependencies; fix converte…
1e93d87 
…r; cleanup code [#27]
dnl-blkv added a commit that referenced this issue Sep 23, 2017
@dnl-blkv
fix init and MonetaryAccountReference [#27]
9df3458
dnl-blkv added a commit that referenced this issue Sep 23, 2017
@dnl-blkv
Add type casts for all the response types [#27]
b6cecd1
dnl-blkv added a commit that referenced this issue Sep 23, 2017
@dnl-blkv
fix docstring param type [#27]
6186fa0
dnl-blkv added a commit that referenced this issue Sep 23, 2017
@dnl-blkv
improve way to set initializers [#27]
217f222
@OGKevin OGKevin added this to the v0.12.0 milestone Sep 23, 2017
dnl-blkv added a commit that referenced this issue Sep 23, 2017
@dnl-blkv
fix variable name [#27]
3e1b12d
dnl-blkv added a commit that referenced this issue Sep 23, 2017
@dnl-blkv
add missing return type [#27]
d1f858f
dnl-blkv added a commit that referenced this issue Sep 25, 2017
@dnl-blkv
fix docs in object and user list example [#27]
efddf3f
dnl-blkv added a commit that referenced this issue Sep 26, 2017
@dnl-blkv
fix location of tests [#27]
68e8977
@dnl-blkv
Copy link
Contributor Author

dnl-blkv commented Oct 6, 2017

Fixed

@dnl-blkv dnl-blkv closed this as completed Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnl-blkv dnl-blkv

Labels
enhancement
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
2 participants
@dnl-blkv @OGKevin