-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support [#16] #17
Conversation
@OGKevin deserialisation is fixed! 👍 |
@dnl-blkv My tests are failing while creating new context.
Line 40 in 40627c5
What could be causing this ? |
Hmm weird just did a clean checkout again merged dev and tests are passing 🤔 |
@@ -57,12 +58,13 @@ class ApiContext(object): | |||
_PATH_API_CONTEXT_DEFAULT = 'bunq.conf' | |||
|
|||
def __init__(self, environment_type, api_key, device_description, | |||
permitted_ips=None): | |||
permitted_ips=None, proxy_url=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function has a lot of arguments, why not reformat it to:
def __init__(self, environment_type, api_key,
device_description, permitted_ips=None, proxy_url=None):
(nicely aligned of course 😉 )
3 args on a row or:
def __init__(
self,
environment_type,
api_key,
device_description,
permitted_ips=None,
proxy_url=None):
1 arg per line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Not PEP-8
- Takes too much space
This one is OK, we do it everywhere :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passing 👏 looks good 🏅
Fixes #16